[vscode] support theme icons #8267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
requested review from
JPinkney,
svenefftinge,
tsmaeder and
vince-fugnitto
akosyakov
added
theming
tsmaeder
reviewed
Jul 30, 2020
| themeIcon = icon; | ||
| } else { | ||
| iconUrl = this.toPluginUrl(pck, icon); | ||
| } | ||
| } else { | ||
| iconUrl = { | ||
| light: this.toPluginUrl(pck, icon.light), |
There was a problem hiding this comment.
I guess since icons from the theme implicitly have a light/dark form, it would be wrong to reference them here, right?
There was a problem hiding this comment.
yes, checked with VS Code that it does not expect codeicons here
| @@ -43,8 +43,11 @@ export class PluginTreeViewNodeLabelProvider implements LabelProviderContributio | |||
| return node.icon; | |||
| } | |||
| if (node.themeIconId) { | |||
| const uri = node.resourceUri && new URI(node.resourceUri) || undefined; | |||
| return this.labelProvider.getIcon(URIIconReference.create(node.themeIconId, uri)); | |||
| if (node.themeIconId === 'file' || node.themeIconId === 'folder') { | |||
There was a problem hiding this comment.
Are these two special-cased so we can get stuff like the "Java" icon for *.java files?
tsmaeder
approved these changes
Jul 30, 2020
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov
force-pushed
the
ak/support_theme_icons
branch
from
14ff865
to
d7b98f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
ExtensionsviewReview checklist
Reminder for reviewers