fix updating items in the quick-pick menu

[vinokurig]

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What it does

Fixes a bug when quick pick items are not updated on the fly.

When a quick open widget is shown, set an instance of the monaco quick-input to the sessions map.
When plugin request's a quick-input items update, they are set to the monaco quick-input instance from the map:

theia/packages/plugin-ext/src/main/browser/quick-open-main.ts

Lines 257 to 262 in d350116

	} else if (param === 'items') {
	handlesToItems.clear();
	params[param].forEach((item: TransferQuickPickItems) => {
	handlesToItems.set(item.handle, item);
	});
	(input as any)[param] = params[param];

How to test

1. Clone and compile the test plugin: https://github.com/microsoft/vscode-extension-samples/tree/main/quickinput-sample
2. Start hosted plugin
3. Execute the Quick Input Samples from the command palette.
4. Choose quickOpen and type something to the input box.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[tsmaeder]

@vinokurig can you describe what the fix does in the code? I.e. what is that basic idea of the code changes in the fix? Also, what was the cause of the bug? Remember to "write shit down" (TM)

[vinokurig]

@tsmaeder

@vinokurig can you describe what the fix does in the code? I.e. what is that basic idea of the code changes in the fix? Also, what was the cause of the bug? Remember to "write shit down" (TM)

Updated the description

[tsmaeder]

@vinokurig I think your change takes the code in the wrong direction: instead of adding "currentInput" state into the QuickInputService, we should add a "createQuickPick" method to the interface and use that in the quick-open-main.ts#$showCustomQuickPick. The current change fails when someone calls QuickInputService#showQuickPick twice in a row. There have been a number of things wrong with this area of the code for a long time which are not your fault, but we should refrain from making the situation worse.

[tsmaeder]

See comment on the main page for the reasons.

[vinokurig]

Opened a PR with different approach #10065