Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating items in the quick-pick menu #10065

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Fix updating items in the quick-pick menu #10065

merged 1 commit into from
Sep 14, 2021

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Sep 8, 2021

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What it does

Rework the quick-input API to use the $createOrUpdate method in the step of initialising the quick-pick instead of using a separate method $showCustomQuickPick

How to test

  1. Clone and compile the test plugin: https://github.com/microsoft/vscode-extension-samples/tree/main/quickinput-sample
  2. Start hosted plugin
  3. Execute the Quick Input Samples from the command palette.
  4. Try all the submenus, especially quickOpen as it is broken in master.

Review checklist

Reminder for reviewers

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's the right behavior, but when I'm choosing quickOpen I see
Screenshot from 2021-09-08 22-36-34

@vinokurig
Copy link
Contributor Author

vinokurig commented Sep 9, 2021

@azatsarynnyy
This command works in the same way in vscode:
Screenshot 2021-09-09 at 08 47 32
The aim is to see some output, in the current master this command shows nothing.

@azatsarynnyy
Copy link
Member

I see. Except quickOpen, it seems other commands work the same as in master branch.

Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look fine to me. As @azatsarynnyy has tested the changes, I'm fine with merging them.

@vinokurig vinokurig merged commit 4924bc7 into master Sep 14, 2021
@vinokurig vinokurig deleted the che-20316_1 branch September 14, 2021 15:43
@github-actions github-actions bot added this to the 1.18.0 milestone Sep 14, 2021
RomanNikitenko pushed a commit that referenced this pull request Sep 16, 2021
Rework the quick-input API to use the $createOrUpdate method in the step of initialising the quick-pick instead of using a separate method $showCustomQuickPick
RomanNikitenko pushed a commit that referenced this pull request Sep 16, 2021
Rework the quick-input API to use the $createOrUpdate method in the step of initialising the quick-pick instead of using a separate method $showCustomQuickPick
azatsarynnyy pushed a commit to redhat-developer/eclipse-theia that referenced this pull request Sep 23, 2021
Rework the quick-input API to use the $createOrUpdate method in the step of initialising the quick-pick instead of using a separate method $showCustomQuickPick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants