-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix updating items in the quick-pick menu #10065
Conversation
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azatsarynnyy |
I see. Except |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look fine to me. As @azatsarynnyy has tested the changes, I'm fine with merging them.
Rework the quick-input API to use the $createOrUpdate method in the step of initialising the quick-pick instead of using a separate method $showCustomQuickPick
Rework the quick-input API to use the $createOrUpdate method in the step of initialising the quick-pick instead of using a separate method $showCustomQuickPick
Rework the quick-input API to use the $createOrUpdate method in the step of initialising the quick-pick instead of using a separate method $showCustomQuickPick
Signed-off-by: Igor Vinokur ivinokur@redhat.com
What it does
Rework the quick-input API to use the
$createOrUpdate
method in the step of initialising the quick-pick instead of using a separate method$showCustomQuickPick
How to test
Quick Input Samples
from the command palette.quickOpen
as it is broken in master.Review checklist
Reminder for reviewers