-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement automatic translation updates #11437
Conversation
3d406e1
to
e0ca87d
Compare
50fb35e
to
07de848
Compare
406ef3e
to
45f61bd
Compare
"missingConfiguration": "Dynamická konfigurace '{0}:{1}' chybí nebo není použitelná", | ||
"open-disassembly-view": "Otevřený pohled na demontáž", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wouldn't do the nls.metadata.json
update in this repo (as that would break translation in an unexpected fashion), but probably somewhere else where we can simply download the file from. I generally agree with your idea and we can likely implement this in the translation-update.js
script. However, would it be alright with you to tackle this in a separate PR/issue? I believe it'd be quite a lot of work and a bit outside of the scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an issue here: #11443
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable 👍
c861cc7
to
8548ed1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some misgivings about the quality of the automatic translations, but this PR appears to accomplish its goals.
What it does
Closes #10885
Runs the
theia nls-extract
andtheia nls-localize
workflow on every PR to create a commit that automatically translates all added content.How to test
Automatic translation update
nls.json
and localizes them automatically into different languagesReview checklist
Reminder for reviewers