Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement automatic translation updates #11437

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Jul 18, 2022

What it does

Closes #10885

Runs the theia nls-extract and theia nls-localize workflow on every PR to create a commit that automatically translates all added content.

How to test

  1. This PR should contain an automatically generated commit named Automatic translation update
  2. The commit adds any missing values to the nls.json and localizes them automatically into different languages

Review checklist

Reminder for reviewers

@msujew msujew added ci issues related to CI / tests localization issues related to localization/internalization/nls labels Jul 18, 2022
@msujew msujew force-pushed the msujew/automatic-localization-update branch 3 times, most recently from 3d406e1 to e0ca87d Compare July 18, 2022 16:21
@msujew msujew force-pushed the msujew/automatic-localization-update branch 2 times, most recently from 50fb35e to 07de848 Compare July 18, 2022 17:12
@msujew msujew force-pushed the msujew/automatic-localization-update branch from 406ef3e to 45f61bd Compare July 18, 2022 17:21
@msujew msujew marked this pull request as ready for review July 18, 2022 17:27
"missingConfiguration": "Dynamická konfigurace '{0}:{1}' chybí nebo není použitelná",
"open-disassembly-view": "Otevřený pohled na demontáž",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know any Czech, but this differs quite substantially from the corresponding VSCode translation:
image

Might it be possible to do a nls.json update so that we can use checked translations where available before we implement this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wouldn't do the nls.metadata.json update in this repo (as that would break translation in an unexpected fashion), but probably somewhere else where we can simply download the file from. I generally agree with your idea and we can likely implement this in the translation-update.js script. However, would it be alright with you to tackle this in a separate PR/issue? I believe it'd be quite a lot of work and a bit outside of the scope of this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an issue here: #11443

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable 👍

@msujew msujew force-pushed the msujew/automatic-localization-update branch from c861cc7 to 8548ed1 Compare July 20, 2022 15:35
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some misgivings about the quality of the automatic translations, but this PR appears to accomplish its goals.

@msujew msujew merged commit 21aa763 into master Jul 26, 2022
@msujew msujew deleted the msujew/automatic-localization-update branch July 26, 2022 13:52
@github-actions github-actions bot added this to the 1.28.0 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to CI / tests localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regular translation update
2 participants