-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align border-radius with vscode #12252
Conversation
91b9046
to
c4c4ab3
Compare
c4c4ab3
to
f69b799
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the changes look good to me, I noticed two missing areas when testing:
- the
AlertMessage
are not rounded (ex: when no workspace is present and we check thescm
view) - the
theia-select
(select input) are not rounded
Thanks Vince for looking it. I've adjusted those two (actually three see ebbbdc2) points. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The rounded borders in the quick-open menus will likely be contributed by newer monaco versions.
What it does
VSCode has recently updated a lot of their UI to use border radius' (menus, menu bars, notifications, buttons, text boxes, quick input etc.). This change aligns Theia to this design decision.
How to test
Assert that the changed elements align with vscode in regards to their border design.
Review checklist
Reminder for reviewers