Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove erroneous dialog min-height styling #12662

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Jun 29, 2023

What it does

During #12252 I accidentally added a styling rule while resolving a merge conflict that makes some dialogs unexpectedly large and weird looking. See:

image

How to test

Open a dialog, confirm that the height is calculated as expected.

Review checklist

Reminder for reviewers

@msujew msujew added the ui/ux issues related to user interface / user experience label Jun 29, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants