[Plugin-API] Apply window.createQuickPick() #5012

vinokurig · 2019-04-26T10:05:02Z

Apply window.createQuickPick() plugin API function. The function wraps QuickOpenExtImpl to set and show a QuickPick menu. Other functionality is not implemented because it require a lot of changes in the Theia quick-open model.
Is needed for #4266
fixes #4987

benoitf · 2019-04-26T10:14:21Z

Hi @vinokurig do you have run https://github.com/Microsoft/vscode/blob/master/extensions/vscode-api-tests/src/singlefolder-tests/quickInput.test.ts against this ?

akosyakov · 2019-04-26T16:43:36Z

Other functionality is not implemented because it require a lot of changes in the Theia quick-open model.

Could you please open an issue to list everything what should be implemented? that it does not get lost in the code... or don't declare what is not implemented if it does no cause runtime issues

vinokurig · 2019-05-02T10:19:46Z

@akosyakov

Could you please open an issue to list everything what should be implemented? that it does not get lost in the code... or don't declare what is not implemented if it does no cause runtime issues

Opened related issue for missing functionality: #5059

vinokurig · 2019-05-02T10:22:53Z

@benoitf

Hi @vinokurig do you have run https://github.com/Microsoft/vscode/blob/master/extensions/vscode-api-tests/src/singlefolder-tests/quickInput.test.ts against this ?

Those are VsCode tests, they will probably fail because we have related issues for not implemented functionality: #5059

akosyakov · 2019-05-03T08:57:55Z

I'm trying to test with https://github.com/Microsoft/vscode-extension-samples/tree/master/quickinput-sample

but plugin host process cannot start for me with this PR:

root INFO Theia app listening on http://localhost:3000.
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /workspace/theia/plugins/quickinput-sample
root INFO Resolved "quickinput-sample" to a VS Code extension "quickinput-sample@0.0.1" with engines: { vscode: '^1.26.0' }
root INFO Deploying backend plugin "quickinput-sample@0.0.1" from "/workspace/theia/plugins/quickinput-sample/out/extension.js"
root WARN Collided keybinding is ignored;  {"command":"terminal:new:active:workspace","keybinding":"ctrl+`"}  collided with  {"command":"terminal:new","keybinding":"ctrl+shift+`"}
root WARN Could not register keybinding:
  {"command":"terminal:new:active:workspace","keybinding":"ctrl+`"}
Error: "ctrl+`" is in collision with something else [scope:0]
root WARN LanguagesFrontendContribution.onStart is slow, took: 121.40500009991229 ms
root INFO Using Git [2.19.1] from the PATH. (/usr/bin/git)
root INFO [nsfw-watcher: 7716] Started watching: /home/gitpod/.theia
root ERROR [hosted-plugin: 7731] /workspace/theia/node_modules/inversify/lib/annotation/decorator_utils.js:22
    if (Reflect.hasOwnMetadata(metadataKey, annotationTarget)) {
                ^

TypeError: Reflect.hasOwnMetadata is not a function
    at _tagParameterOrProperty (/workspace/theia/node_modules/inversify/lib/annotation/decorator_utils.js:22:17)
    at Object.tagParameter (/workspace/theia/node_modules/inversify/lib/annotation/decorator_utils.js:7:5)
    at /workspace/theia/node_modules/inversify/lib/annotation/named.js:10:31
    at /workspace/theia/packages/core/lib/common/command.js:27:37
    at __decorate (/workspace/theia/packages/core/lib/common/command.js:20:95)
    at /workspace/theia/packages/core/lib/common/command.js:386:23
    at Object.<anonymous> (/workspace/theia/packages/core/lib/common/command.js:392:2)
    at Module._compile (internal/modules/cjs/loader.js:701:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:712:10)
    at Module.load (internal/modules/cjs/loader.js:600:32)

akosyakov · 2019-05-03T08:58:41Z

@vinokurig How can I test it?

vinokurig · 2019-05-03T12:58:43Z

@akosyakov Fixed the error, now you can test it with the sample plugin

akosyakov · 2019-05-03T14:06:27Z

packages/plugin-ext/src/plugin/quick-open.ts

+            this.onDidAcceptEmitter.fire(undefined);
+            this.onDidChangeSelectionEmitter.fire([item]);
+            this.onDidHideEmitter.fire(undefined);
+            this.dispose();


Should not it be done by a client? Can a client call show several items on the same instance of quick open?

packages/plugin-ext/src/plugin/quick-open.ts

akosyakov · 2019-05-03T14:12:09Z

I'm getting errors in the backend console trying different combinations from the sample extension:

root ERROR [hosted-plugin: 4427] TypeError: vscode_1.window.createInputBox is not a function
    at Promise (/workspace/theia/plugins/quickinput-sample/out/multiStepInput.js:233:51)
    at new Promise (<anonymous>)
    at MultiStepInput.<anonymous> (/workspace/theia/plugins/quickinput-sample/out/multiStepInput.js:232:30)
    at Generator.next (<anonymous>)
    at /workspace/theia/plugins/quickinput-sample/out/multiStepInput.js:11:71
    at new Promise (<anonymous>)
    at __awaiter (/workspace/theia/plugins/quickinput-sample/out/multiStepInput.js:7:12)
    at MultiStepInput.showInputBox (/workspace/theia/plugins/quickinput-sample/out/multiStepInput.js:229:16)
    at /workspace/theia/plugins/quickinput-sample/out/multiStepInput.js:80:42
    at Generator.next (<anonymous>)

root ERROR [hosted-plugin: 4427] TypeError: Cannot read property 'map' of undefined
    at QuickPickExt.show (/workspace/theia/packages/plugin-ext/lib/plugin/quick-open.js:225:49)
    at Promise (/workspace/theia/plugins/quickinput-sample/out/quickOpen.js:105:23)
    at new Promise (<anonymous>)
    at /workspace/theia/plugins/quickinput-sample/out/quickOpen.js:56:26
    at Generator.next (<anonymous>)
    at /workspace/theia/plugins/quickinput-sample/out/quickOpen.js:11:71
    at new Promise (<anonymous>)
    at __awaiter (/workspace/theia/plugins/quickinput-sample/out/quickOpen.js:7:12)
    at pickFile (/workspace/theia/plugins/quickinput-sample/out/quickOpen.js:53:12)
    at Object.<anonymous> (/workspace/theia/plugins/quickinput-sample/out/quickOpen.js:27:27)

vinokurig · 2019-05-03T14:45:57Z

@akosyakov

I'm getting errors in the backend console trying different combinations from the sample extension:
root ERROR [hosted-plugin: 4427] TypeError: vscode_1.window.createInputBox is not a function

That's because window.createInputBox API method is not implemented yet

akosyakov · 2019-05-06T04:54:24Z

@vinokurig and the second error? i thought the quick open is already implemented. Is it a bug in the implementation, please open an issue.

akosyakov

I'm not happy with stubbing stuff, but in this case it seems to cause runtime errors for methods/events. I hope we can implement them soon.

cc @benoitf

vinokurig · 2019-05-06T07:02:12Z

@akosyakov Fixed the second error in the PR

vinokurig · 2019-05-08T06:55:05Z

@benoitf Can we go with current state?

benoitf · 2019-05-14T06:23:38Z

@vinokurig yes, please check first that commits are Signed (DCO and eca checks are failing)

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

vinokurig requested review from benoitf, evidolob and azatsarynnyy April 26, 2019 10:05

vinokurig force-pushed the theia-4987 branch from ae4e93e to cb828da Compare April 26, 2019 10:05

vinokurig mentioned this pull request May 2, 2019

[Plugin-API] Improve window.createQuickPick() #5059

Open

13 tasks

vinokurig force-pushed the theia-4987 branch from cb828da to dd759ea Compare May 2, 2019 10:20

vinokurig force-pushed the theia-4987 branch from dd759ea to 55c59f1 Compare May 2, 2019 10:26

akosyakov reviewed May 3, 2019

View reviewed changes

packages/plugin-ext/src/plugin/quick-open.ts Show resolved Hide resolved

akosyakov approved these changes May 6, 2019

View reviewed changes

vinokurig mentioned this pull request May 10, 2019

[Plugin-Api] Apply window.createInput() function #5108

Closed

benoitf approved these changes May 14, 2019

View reviewed changes

[Plugin-API] Apply window.createQuickPick()

ded06fc

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

vinokurig force-pushed the theia-4987 branch from e9c36d7 to ded06fc Compare May 14, 2019 09:05

vinokurig merged commit 126ac74 into master May 14, 2019

vinokurig deleted the theia-4987 branch May 14, 2019 09:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Plugin-API] Apply window.createQuickPick() #5012

[Plugin-API] Apply window.createQuickPick() #5012

vinokurig commented Apr 26, 2019

benoitf commented Apr 26, 2019

akosyakov commented Apr 26, 2019 •

edited

Loading

vinokurig commented May 2, 2019

vinokurig commented May 2, 2019

akosyakov commented May 3, 2019

akosyakov commented May 3, 2019

vinokurig commented May 3, 2019

akosyakov May 3, 2019

vinokurig May 3, 2019

akosyakov commented May 3, 2019

vinokurig commented May 3, 2019 •

edited

Loading

akosyakov commented May 6, 2019

akosyakov left a comment

vinokurig commented May 6, 2019

vinokurig commented May 8, 2019

benoitf commented May 14, 2019

[Plugin-API] Apply window.createQuickPick() #5012

[Plugin-API] Apply window.createQuickPick() #5012

Conversation

vinokurig commented Apr 26, 2019

benoitf commented Apr 26, 2019

akosyakov commented Apr 26, 2019 • edited Loading

vinokurig commented May 2, 2019

vinokurig commented May 2, 2019

akosyakov commented May 3, 2019

akosyakov commented May 3, 2019

vinokurig commented May 3, 2019

akosyakov May 3, 2019

Choose a reason for hiding this comment

vinokurig May 3, 2019

Choose a reason for hiding this comment

akosyakov commented May 3, 2019

vinokurig commented May 3, 2019 • edited Loading

akosyakov commented May 6, 2019

akosyakov left a comment

Choose a reason for hiding this comment

vinokurig commented May 6, 2019

vinokurig commented May 8, 2019

benoitf commented May 14, 2019

akosyakov commented Apr 26, 2019 •

edited

Loading

vinokurig commented May 3, 2019 •

edited

Loading