[Plugin-Api] Apply window.createInput() function #5108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azatsarynnyy
approved these changes
May 10, 2019
benoitf
approved these changes
May 17, 2019
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
|
@akosyakov Can we go with this? |
|
@vinokurig would be nice to test it against vscode api tests as well |
|
@benoitf Do you have any instructions how to run VsCode tests on Theia? |
akosyakov
reviewed
Jul 3, 2019
There was a problem hiding this comment.
I would prefer to close it in favor of #5187. And don't accept PRs stubbing APIs anymore, but PRs which actually implement something even if not complete. Otherwise it makes hard to track the real implementation progress and does not really bring value to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply
window.createInput()plugin API function. The function wraps QuickOpenExtImpl to setup and show an input notification. Other functionality is not implemented because it require a lot of changes in the Theia quick-input model.Tested in pair with #5012 on https://github.com/Microsoft/vscode-extension-samples/tree/master/quickinput-sample
fixes #5107