-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply overlay keyboard events to the top most dialog #5865
Conversation
@xieyuanhuata please try whether it behaves as you expect |
@akosyakov Great, this is the effect which I want. |
@vince-fugnitto could you give it a go? if you are fine please approve and i will remove test commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it using the example commit you provided and it works as intended.
I performed the following test:
- trigger the
open
dialog - click the temporary
open single text button
which opens a SingleTextInputDialog` - press esc, only the
SingleTextInputDialog
is closed - press esc, the
open
dialog is closed
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
I've dropped the test commit, merging if CI is green and no objections. |
What it does
How to test
I've pushed a temporary commit which adds a button to the open file dialog that one can open another dialog from the first. One can use it to test that on esc and enter the top-most dialog receives events. I remove this commit after the review.
Review checklist
Reminder for reviewers