Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply overlay keyboard events to the top most dialog #5865

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Aug 6, 2019

What it does

How to test

I've pushed a temporary commit which adds a button to the open file dialog that one can open another dialog from the first. One can use it to test that on esc and enter the top-most dialog receives events. I remove this commit after the review.

Review checklist

Reminder for reviewers

@akosyakov
Copy link
Member Author

@xieyuanhuata please try whether it behaves as you expect

@akosyakov akosyakov added the shell issues related to the core shell label Aug 6, 2019
@xieyuanhuata
Copy link
Contributor

xieyuanhuata commented Aug 6, 2019

@akosyakov Great, this is the effect which I want.

@akosyakov
Copy link
Member Author

@vince-fugnitto could you give it a go? if you are fine please approve and i will remove test commit

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it using the example commit you provided and it works as intended.
I performed the following test:

  1. trigger the open dialog
  2. click the temporary open single text button which opens a SingleTextInputDialog`
  3. press esc, only the SingleTextInputDialog is closed
  4. press esc, the open dialog is closed

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Member Author

I've dropped the test commit, merging if CI is green and no objections.

@akosyakov akosyakov merged commit 0953ba7 into master Aug 8, 2019
@akosyakov akosyakov deleted the GH-5859 branch August 8, 2019 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shell issues related to the core shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The dialog responding to the esc/enter button is unfriendly
4 participants