don't show view containers with hidden views on startup #6141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ don't show tree views eagerly Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov
requested review from
AlexTugarev,
svenefftinge,
vince-fugnitto and
vinokurig
akosyakov
added
plug-in system
svenefftinge
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
fix #6139:
How to test
testview container should not be visibleConfigure Testspython commandtestview container should appearFor views without
whenclosure install https://github.com/microsoft/vscode-extension-samples/tree/master/tree-view-sample check that views are present.Review checklist
Reminder for reviewers