Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't show view containers with hidden views on startup #6141

Merged
merged 1 commit into from
Sep 9, 2019
Merged

don't show view containers with hidden views on startup #6141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/plugin-ext/src/main/browser/view/plugin-view-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,13 @@ export class PluginViewRegistry implements FrontendApplicationContribution {
}

protected async updateViewVisibility(viewId: string): Promise<void> {
const widget = await this.getView(viewId);
if (!widget) {
if (this.isViewVisible(viewId)) {
await this.openView(viewId);
}
return;
}
const viewInfo = this.views.get(viewId);
if (!viewInfo) {
return;
Expand All @@ -157,10 +164,6 @@ export class PluginViewRegistry implements FrontendApplicationContribution {
if (!viewContainer) {
return;
}
const widget = await this.getView(viewId);
if (!widget) {
return;
}
const part = viewContainer.getPartFor(widget);
if (!part) {
return;
Expand Down Expand Up @@ -378,8 +381,8 @@ export class PluginViewRegistry implements FrontendApplicationContribution {
let viewContainer = await this.getPluginViewContainer(id);
if (!viewContainer) {
viewContainer = await this.openViewContainer(id);
if (viewContainer && !viewContainer.getTrackableWidgets().length) {
// close empty view containers
if (viewContainer && !viewContainer.getParts().filter(part => !part.isHidden).length) {
// close view containers without any visible view parts
viewContainer.dispose();
}
} else {
Expand Down
1 change: 0 additions & 1 deletion packages/plugin-ext/src/main/browser/view/tree-views-main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ export class TreeViewsMainImpl implements TreeViewsMain {
this.handleTreeEvents(widget.id, widget);
return widget;
}));
await this.viewRegistry.openView(treeViewId);
}

async $unregisterTreeDataProvider(treeViewId: string): Promise<void> {
Expand Down