Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin] start document listening when all clients are ready #6321

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Oct 3, 2019

What it does

Otherwise events for already opened document can be missed.

How to test

  • install vscode go extension
  • install some go project, i.e. go get github.com/petar/GoLLRB/llrb
  • configure preference to use go LS and see its tracing information:
{
  "gopls.trace.server": "verbose",
  "go.useLanguageServer": true
}
  • open go project and open a file
  • open gopls output view
  • check that didOpen, didChange, didClose events are delivered whenever you do a corresponding action
  • make sure to test it after reload with preserved editors
  • also test it with reconnections by restarting the backend

Hint: you can clean the output view when an event should be at the top

Review checklist

Reminder for reviewers

Otherwise events for already opened document can be missed.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Oct 3, 2019
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense 👍

@akosyakov akosyakov merged commit 0bb4c49 into master Oct 4, 2019
@akosyakov akosyakov deleted the GH-6319 branch October 4, 2019 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plugin] initial document deltas are missing sometimes
3 participants