Fix plugin icon URLs in electron & Fix custom icon themes

[owlJaeger]

Signed-off-by: Luca Jaeger owl.jaeger@gmail.com

What it does

Fixes Issues:

• [theming] unable to successfully display custom file icons in electron #6834
• [Electron] Plugins icons not showed on Electron #7040

#6834 Fixed by:

• plugin-protocol.ts:
  • Replace PluginModel.packagePath with a backend-created FileUri passed on as PluginModel.packageUri instead of PluginModel.packagePath
• scanner-vscode.ts & scanner-theia.ts:
  • Pass on a backend-generated FileUri through the PluginModel.packageUri property.
• plugin-api-rpc.ts:
  • Updated the empty Model to include packageUri
• plugin-icon-theme-service.ts:
  • Updated to use packageUri instead of packagePath and fix the relativePath being undefined on Windows.
  • Using Endpoints to fix it for electron specifically.

#7040 Fixed by:

• Using Endpoints in these files:
  • plugin-shared-style.ts
  • plugin-view-registry.ts

How to test

• [theming] unable to successfully display custom file icons in electron #6834: Test by building the electron and browser example apps in the theia repository and using the Seti File Icon Theme or download other icon themes through vsx-registry.
• [Electron] Plugins icons not showed on Electron #7040: Test by building the electron example app in the theia repository and install an extension like Gitlens.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

Please be sure to properly sign the Eclipse ECA, I see that your sign-off email is not yet registered:

[owlJaeger]

Should be registered now

[vince-fugnitto]

I verified the functionality present on electron and it works very well:

• I am able to successfully update/render file-icon themes.
• I am able to successfully view icons provided by plugins (such as gitlens)

I also tested the browser to see if there were any regressions.

Additional Info

• macOS

[owlJaeger]

Do these changes meet your expectations @akosyakov?

[akosyakov]

@owlJaeger it looks very promising, i'm going to test it.

[akosyakov]

It looks good code-wise to me and I've tested that icons are available for themes, commands, trees and view containers in browser/electron targets on Linux. I have not tested on Windows.

I think we should mark PluginModel.packagePath as deprecated and tell to use packageUri instead. Clean up can be done later.

[owlJaeger]

Shall I update the Changelog for that? I see there are more deprecation warnings under the breaking changes section.

[akosyakov]

Shall I update the Changelog for that? I see there are more deprecation warnings under the breaking changes section.

Yes, you can mention it. Don't delete code yet, only deprecate.

[akosyakov]

@kittaakos Would you be able to check whether on Windows you have icons for electron?

[owlJaeger]

Updated to include the deprecation warning and rebased to include newest commits from theia/master. Now with the JS-Doc tag.

[akosyakov]

merging tomorrow if no objections?