Improve Documentation for PreferenceContribution and related types
#8677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
documentation
vince-fugnitto
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
@tortmayr the changes look very good, I only had some very minor feedback.
packages/core/src/browser/preferences/preference-contribution.ts
Outdated
Show resolved
Hide resolved
Fixes eclipse-theia#8676 Contributed on behalf of STMicroelectronics Signed-off-by: Tobias Ortmayr <tortmayr@eclipsesource.com>
|
Thanks for the fast review. I applied your feedback suggestions. |
vince-fugnitto
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8676
Improve Documentation for
PreferenceContributionand related typesContributed on behalf of STMicroelectronics
Signed-off-by: Tobias Ortmayr tortmayr@eclipsesource.com
What it does
Adds/refines documentation for
PreferenceContributionand related types.How to test
Documentation change only
Review checklist
Reminder for reviewers