Improve Documentation for PreferenceContribution and related types
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasHelming
reviewed
Oct 5, 2020
packages/core/src/browser/preferences/preference-contribution.ts
Outdated
Show resolved
Hide resolved
packages/core/src/browser/preferences/preference-contribution.ts
Outdated
Show resolved
Hide resolved
packages/core/src/browser/preferences/preference-contribution.ts
Outdated
Show resolved
Hide resolved
| readonly preferenceName: string; | ||
| /** | ||
| * The new value of the changed preference. |
There was a problem hiding this comment.
what is the meaning if this is not set? Same for oldvalue
packages/core/src/browser/preferences/preference-contribution.ts
Outdated
Show resolved
Hide resolved
|
|
||
| /** | ||
| * Specialized {@link FrontendApplicationConfig} that can be used to configure default | ||
| * preference values for the {@link PreferenceSchemaProvider}. |
There was a problem hiding this comment.
Are these default values really only used by the PreferenceSchemaProvider?
There was a problem hiding this comment.
Yes. At the moment they are only used in the PreferenceSchemaProvider
packages/core/src/browser/preferences/preference-contribution.ts
Outdated
Show resolved
Hide resolved
packages/core/src/browser/preferences/preference-contribution.ts
Outdated
Show resolved
Hide resolved
tortmayr
force-pushed
the
preference
branch
2 times, most recently
from
8e38809 to
85976d6
Compare
sdirix
force-pushed
the
master
branch
2 times, most recently
from
1a30806 to
ca06fc3
Compare
tortmayr
force-pushed
the
preference
branch
2 times, most recently
from
8ceb97e to
203fc7a
Compare
Fixes eclipse-theia#8676 Contributed on behalf of STMicroelectronics Signed-off-by: Tobias Ortmayr <tortmayr@eclipsesource.com>
|
Merged upstream with eclipse-theia#8677 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tobias Ortmayr tortmayr@eclipsesource.com
Contributed on behalf of STMicroelectronics