Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] payload_data column family exists without metadata regarding timestamps #129

Closed
Charles-Schleich opened this issue Jul 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Charles-Schleich
Copy link
Member

Describe the bug

payload_data column family exists and no data_info column Family exists,
currently we are generating a timestamp ZenohId=1 upon retrieval of the data stored and sending the timestamp to zenoh.
However we are not adding the metadata to the database.
With the timestamp rework happening in eclipse-zenoh/zenoh#1188, we no longer have access to the new_reception_timestamp function
This will effect replication logic.

After discussion with @JEnoch, proposed solution to fix this is at start up either:

  1. Refuse to start Plugin if no metadata is detected in database.
    metadata includes, timestamp, deleted flag, and encoding.

  2. Start plugin, and for payloads that do not have meta-data, generate metadata
    its possible to generate metadata for timestamp. but not for deleted flag or encoding.
    I'm not sure this option is possible if we do not know the original encoding of the data.

To reproduce

Start instance of plugin with RocksDB,
with existing Rocksdb database,
and existing payload data but no data_info column family.

System info

zenoh-backend-rocksdb git hash 679be9788309c611ccd29cdff586d4a5a2f17e64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant