fix(storage-manager): do not start when 'timestamping' is disabled #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Loudet
force-pushed
the
fix/prevent-storage-startup-no-timestamping
branch
2 times, most recently
from
8793146 to
ad7063b
Compare
All storage must have a timestamp associated with a Sample.
As it is possible to publish without adding a timestamp, it means that a
Zenoh node must add this timestamp "at some point". Up until now, the
default configuration of a router ('timestamping' enabled) combined with
the fact that only routers could load plugins (and, thus, storage) made
it so that a timestamp was (by default) always added.
Recent changes in Zenoh — namely the fact that not only routers can load
plugins and that peers and client have, by default, the 'timestamping'
configuration disabled — invalidate these assumptions.
We should then enforce at runtime, that the 'timestamping' configuration
is enabled when attempting to load the storage manager.
This commit adds this check by verifying that there is an HLC associated
with the Zenoh Session — the HLC is only created if 'timestamping' is
enabled (see `zenoh/zenoh/src/net/runtime/mod.rs::142`).
* plugins/zenoh-plugin-storage-manager/src/lib.rs: return an error if
the storage manager is started while the configuration option
'timestamping' is disabled.
* plugins/zenoh-plugin-storage-manager/tests/operations.rs: updated
the `config` used in the test to enable 'timestamping'.
* plugins/zenoh-plugin-storage-manager/tests/wildcard.rs: updated the
`config` used in the test to enable 'timestamping'.
Signed-off-by: Julien Loudet <julien.loudet@zettascale.tech>
J-Loudet
force-pushed
the
fix/prevent-storage-startup-no-timestamping
branch
from
ad7063b to
016d759
Compare
|
LGTM. |
JEnoch
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All storage must have a timestamp associated with a Sample.
As it is possible to publish without adding a timestamp, it means that a Zenoh node must add this timestamp "at some point". Up until now, the default configuration of a router ('timestamping' enabled) combined with the fact that only routers could load plugins (and, thus, storage) made it so that a timestamp was (by default) always added.
Recent changes in Zenoh — namely the fact that not only routers can load plugins and that peers and client have, by default, the 'timestamping' configuration disabled — invalidate these assumptions.
We should then enforce at runtime, that the 'timestamping' configuration is enabled when attempting to load the storage manager.
This commit adds this check by verifying that there is an HLC associated with the Zenoh Session — the HLC is only created if 'timestamping' is enabled (see
zenoh/zenoh/src/net/runtime/mod.rs::142).configused in the test to enable 'timestamping'.configused in the test to enable 'timestamping'.