Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make z_null and z_check as internal method #592

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Make z_null and z_check as internal method #592

merged 1 commit into from
Aug 14, 2024

Conversation

sashacmc
Copy link
Member

@sashacmc sashacmc commented Aug 13, 2024 •
edited
Loading

  • z_null renamed to _z_null and removed from public API
  • z_check renamed to _z_check and removed from public API

Closes: #589

@sashacmc
Copy link
Member Author

It was not possible to just rename z_type_null to _z_type_null because of conflicts with the internal methods, so it was renamed to _z_owned_type_null

@sashacmc sashacmc force-pushed the make_null_check_private branch from 76617d4 to fd35448 Compare August 13, 2024 16:17
@sashacmc sashacmc marked this pull request as ready for review August 13, 2024 16:33
@milyin milyin merged commit e7d962b into eclipse-zenoh:dev/1.0.0 Aug 14, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milyin milyin milyin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sashacmc @milyin