-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/rework-include-ts #34
ci/rework-include-ts #34
Conversation
… and tag script in main release
PR missing one of the required labels: {'bug', 'internal', 'breaking-change', 'dependencies', 'documentation', 'enhancement', 'new feature'} |
Comment here, the JS package should be on npm not github, otherwise access it still requires a token. |
.github/workflows/release-plugin.yml
Outdated
|
||
permissions: | ||
contents: write | ||
|
||
on: | ||
push: | ||
tags: | ||
- v[0-9]+.* | ||
- 'v[0-9]+.*' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without the v
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
.github/workflows/release-ts.yml
Outdated
push: | ||
push: | ||
tags: | ||
- v[0-9]+.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without the v and quoted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
.github/workflows/release-plugin.yml
Outdated
@@ -1,12 +1,12 @@ | |||
name: Release | |||
name: Release Plugin | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this whole workflow can be deleted. We have in the release.yml
a job to publish the artifacts created during the build to github and release it as a Github release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the workflow, i was under the impression the workflow was doing the releasing.
@gabrik ive opened an issue in gitlab for the Eclipse Foundation to create a bot on NPM, |
The CI/CD pipeline should include releasing 3 things
Zenoh-ts
packaged and released on npm (github)zenoh-plugin-remote-api
released on githubAll of these things should happen on a push to a version tag
This requires all
Cargo.toml
's andpackage.json
's to be bumped to the same version number.The respective workflows for plugin, docs and plugin will handle publishing.
Debate: Should we allow releasing the library or the plugin manually as well ?