Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/rework-include-ts #34

Merged
merged 9 commits into from
Nov 21, 2024
Merged

Conversation

Charles-Schleich
Copy link
Member

@Charles-Schleich Charles-Schleich commented Nov 14, 2024

The CI/CD pipeline should include releasing 3 things

  • Zenoh-ts packaged and released on npm (github)
  • zenoh-plugin-remote-api released on github
  • Documentation publishing
    All of these things should happen on a push to a version tag
    This requires all Cargo.toml's and package.json's to be bumped to the same version number.

The respective workflows for plugin, docs and plugin will handle publishing.

Debate: Should we allow releasing the library or the plugin manually as well ?

Copy link

PR missing one of the required labels: {'bug', 'internal', 'breaking-change', 'dependencies', 'documentation', 'enhancement', 'new feature'}

@Charles-Schleich Charles-Schleich added the internal Changes not included in the changelog label Nov 14, 2024
@gabrik
Copy link
Contributor

gabrik commented Nov 14, 2024

Comment here, the JS package should be on npm not github, otherwise access it still requires a token.


permissions:
contents: write

on:
push:
tags:
- v[0-9]+.*
- 'v[0-9]+.*'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without the v

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

push:
push:
tags:
- v[0-9]+.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without the v and quoted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@@ -1,12 +1,12 @@
name: Release
name: Release Plugin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this whole workflow can be deleted. We have in the release.yml a job to publish the artifacts created during the build to github and release it as a Github release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the workflow, i was under the impression the workflow was doing the releasing.

@Charles-Schleich
Copy link
Member Author

@gabrik ive opened an issue in gitlab for the Eclipse Foundation to create a bot on NPM,
once they create that bot i will integrate publishing to npm in the CI/CD (Should just require an update to the .npmrc)
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5279

@milyin milyin merged commit e13def4 into eclipse-zenoh:main Nov 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants