Add bumping of internal deps for plugin #44
Conversation
|
PR missing one of the required labels: {'dependencies', 'bug', 'internal', 'enhancement', 'new feature', 'breaking-change', 'documentation'} |
|
Need to update the release.yml workflow to include the patterns like here: https://github.com/eclipse-zenoh/zenoh-python/blob/main/.github/workflows/release.yml#L52-L54 |
Charles-Schleich
changed the title
|
|
||
| if [[ -n $bump_deps_branch ]]; then | ||
| toml_set_in_place Cargo.toml "workspace.dependencies.$dep.branch" "$bump_deps_branch" | ||
| fi |
There was a problem hiding this comment.
As mentioned on Discord, this needs update as well similar to how it's done for zenoh-c opaque-types: https://github.com/eclipse-zenoh/zenoh-c/blob/main/ci/scripts/bump-and-tag.bash#L76, so https://github.com/eclipse-zenoh/zenoh-ts/blob/main/zenoh-plugin-remote-api/Cargo.toml#L91 gets bumped too.
There was a problem hiding this comment.
Added update of package.metadata.deb.depends
| cargo check | ||
|
|
||
| if [[ -n $bump_deps_version || -n $bump_deps_branch ]]; then | ||
| git commit Cargo.toml Cargo.lock -m "chore: Bump $bump_deps_pattern version to $bump_deps_version" |
There was a problem hiding this comment.
I think you also have to commit the change of the zenoh-plugin-remote-api/Cargo.toml file
No description provided.