-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check crate MSRVs #1026
base: main
Are you sure you want to change the base?
Check crate MSRVs #1026
Conversation
@fuzzypixelz what's the status of this PR? Is it ready for review? |
Right now it seems to report incorrect MSRVs. I would have to investigate that first. |
The issue wasn't that the job was reporting incorrect MSRVs. But that the MSRV of the crate On the ubuntu-latest runner (i.e. This MSRV business is more complicated than I first thought... |
a7a2906
to
3061ebe
Compare
The problem now is handling platform-specific MSRVs. Right now we check that the If crate C1 on platform P1 has an MSRV of V1 and an MSRV of V2 on platform P2. Then the checks on platforms P1 and P2 cannot both succeed. We cannot tolerate a |
The other problem is that cargo-msrv fails to install toolchains on windows-latest with error: error: could not create link from 'C:\\Users\\runneradmin\\.cargo\\bin\\rustup.exe' to 'C:\\Users\\runneradmin\\.cargo\\bin\\cargo.exe' It seemingly cannot create a (symbolic? hard?) link. This is very odd since the |
This add a check for the MSRV of all crates in the workspace. Each crate has its own MSRV specified through
package.rust-version
.