Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expression caching to routing Resource tree #1680

Merged
merged 9 commits into from
Jan 8, 2025
Merged

Conversation

OlivierHecart
Copy link
Contributor

The full key expression string is stored in each Resource of the routing Resource tree so that Resource::expr does not need to perform recursive string concatenation to rebuild the full key expression string. This consumes more memory but saves a lot of CPU.

@OlivierHecart OlivierHecart added the enhancement Existing things could work better label Dec 19, 2024
@OlivierHecart
Copy link
Contributor Author

Waiting #1678

@OlivierHecart OlivierHecart marked this pull request as ready for review January 7, 2025 16:32
@Mallets Mallets enabled auto-merge (squash) January 8, 2025 11:02
@Mallets Mallets merged commit c5709d0 into main Jan 8, 2025
25 checks passed
@OlivierHecart OlivierHecart deleted the dev/expression_caching branch January 8, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants