Compile with Rust 1.47 #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the Rust compiler Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
|
I've updated this PR after the sync branch has been merged, unfortunately flume depends on spinning_top, which uses the newer spin_loop API (https://github.com/rust-osdev/spinning_top/blob/master/src/spinlock.rs#L57). I could submit a patch to spinning_top so that it uses one API or the other depending on the version of the Rust compiler, or I could package a more recent version of Rust and Cargo in a vendor package for ROS. The latter seems the path of least resistance, so that's probably the one I'll follow. |
|
This PR is inactive for more than a year. Closing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the zenoh bridge to the ROS index, I tested if it could be built by the version of the Rust compiler that Ubuntu ships with (1.47). I'm avoiding rustup so that the ROS buildfarm can build packages cleanly without dependencies that can't be installed via APT.