Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorings/exterminate statics #3837

Merged
merged 98 commits into from
Feb 6, 2024

Conversation

dseurotech
Copy link
Contributor

@dseurotech dseurotech commented Aug 2, 2023

Brief description of the PR.
Removes most static variables and manual singletons, in favour of a more pervasive Dependency Injection usage.

Related Issue
This PR fixes/closes 3266

Description of the solution adopted

Exterminating Statics.pdf

Any side note on the changes made

  • A lot of code cleanups
  • Reworked the structure of data store classes (iteraction with Elastic Search)

@dseurotech dseurotech force-pushed the refactorings/exterminateStatics branch from 42b801c to 01e868e Compare August 2, 2023 09:52
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Attention: 741 lines in your changes are missing coverage. Please review.

Comparison is base (1d45940) 0.00% compared to head (b8e989e) 21.18%.
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #3837       +/-   ##
==============================================
+ Coverage           0   21.18%   +21.18%     
- Complexity         0       10       +10     
==============================================
  Files              0     1938     +1938     
  Lines              0    41181    +41181     
  Branches           0     3780     +3780     
==============================================
+ Hits               0     8724     +8724     
- Misses             0    32051    +32051     
- Partials           0      406      +406     
Files Coverage Δ
...emis/plugin/security/setting/BrokerSettingKey.java 0.00% <ø> (ø)
...mmons/rest/filters/settings/RestFiltersModule.java 100.00% <100.00%> (ø)
...stractKapuaConfigurableResourceLimitedService.java 0.00% <ø> (ø)
...a/commons/core/ServiceModuleJaxbClassProvider.java 0.00% <ø> (ø)
...e/kapua/commons/crypto/setting/CryptoSettings.java 100.00% <ø> (ø)
...va/org/eclipse/kapua/commons/event/ServiceMap.java 14.28% <ø> (ø)
.../eclipse/kapua/commons/jpa/EntityCacheFactory.java 100.00% <100.00%> (ø)
...e/kapua/commons/jpa/KapuaEntityManagerFactory.java 54.34% <100.00%> (ø)
...pse/kapua/commons/jpa/NamedEntityCacheFactory.java 100.00% <100.00%> (ø)
.../kapua/commons/liquibase/KapuaLiquibaseClient.java 80.39% <100.00%> (ø)
... and 146 more

... and 1782 files with indirect coverage changes

@dseurotech dseurotech force-pushed the refactorings/exterminateStatics branch 5 times, most recently from 5c425b7 to d9e37d9 Compare August 11, 2023 08:38
@dseurotech dseurotech force-pushed the refactorings/exterminateStatics branch 11 times, most recently from e72dcdf to 9e76f14 Compare August 22, 2023 12:41
@dseurotech dseurotech force-pushed the refactorings/exterminateStatics branch 10 times, most recently from 70ab4ed to 8b45732 Compare September 6, 2023 08:56
@dseurotech dseurotech force-pushed the refactorings/exterminateStatics branch 2 times, most recently from da4a57a to a75429b Compare September 6, 2023 10:10
…osed anyway

Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
…iscovery

Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
…rvice

Signed-off-by: dseurotech <davide.salvador@eurotech.com>
…ation and increasing configurability

Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
@dseurotech dseurotech force-pushed the refactorings/exterminateStatics branch from 8c49b80 to 047bdbe Compare February 5, 2024 07:30
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
@Coduz Coduz added CQ approved The PR has passed CQ approvation and removed CQ pending This PR needs a CQ to be approved from Eclipse before merging. labels Feb 6, 2024
@Coduz Coduz merged commit f913868 into eclipse:develop Feb 6, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CQ approved The PR has passed CQ approvation Enhancement This PR/Issue improves an part of Kapua
Projects
Development

Successfully merging this pull request may close these issues.

'static final' use should be avoided in class fields
2 participants