Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve system properties/environment variables while browsing the application.properties values #448

Closed
fbricon opened this issue Jun 26, 2024 · 5 comments · Fixed by #456
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@fbricon
Copy link
Contributor

fbricon commented Jun 26, 2024

Originally reported as redhat-developer/intellij-quarkus#1331

It would be nice if the current System properties (eg. user.name) is resolved while browsing the application.properties values:
image

it is supported in MP Config according to @gastaldi

*_KEY, *_SECRET and *_PASSWORD should be obfuscated.

I initially started looking at an IJ implem in fbricon/intellij-quarkus@a22b996 (validation and completion still didn't work), but this should better be done at the language server level directly.

@fbricon fbricon added the enhancement New feature or request label Jun 26, 2024
@fbricon fbricon moved this to 📋 Backlog in IDE Cloudaptors Jun 26, 2024
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 14, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 14, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr moved this from 📋 Backlog to 👀 In review in IDE Cloudaptors Aug 14, 2024
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 14, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 14, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 14, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 14, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 14, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 14, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 14, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 15, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 15, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 16, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 16, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 16, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 16, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 16, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 16, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 16, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 16, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 16, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 16, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 16, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 16, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Aug 16, 2024
application.properties values

Fixes eclipse#448

Signed-off-by: azerr <azerr@redhat.com>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Aug 16, 2024
@angelozerr angelozerr added this to the 0.12.0 milestone Aug 16, 2024
@angelozerr
Copy link
Contributor

@gastaldi once https://github.com/redhat-developer/intellij-quarkus/actions/runs/10422663550 will be finished, please install https://github.com/redhat-developer/intellij-quarkus?tab=readme-ov-file#testing-nightly-builds to enjoy with this feature.

@gastaldi
Copy link

@angelozerr works beautifully in apps using application.properties, good job!

But I noticed that it doesn't work when using application.yaml, is that intended?

@angelozerr
Copy link
Contributor

angelozerr commented Aug 19, 2024

@angelozerr works beautifully in apps using application.properties, good job!

Thanks!

But I noticed that it doesn't work when using application.yaml, is that intended?

I have not worked on that.I dont know if it will be easy to implement it.

@angelozerr
Copy link
Contributor

angelozerr commented Aug 20, 2024

But I noticed that it doesn't work when using application.yaml, is that intended?

The YAML support is managed with a JSON Schema (we generate a JSON Schema with all available properties like mp, quarkus, etc and we associate it to the yaml editor). It means that we don't manage any completion, validation, hover, etc, we let the Editor/IDE (vscode, IJ, Eclipse IDE) supporting completion, validation...

It avoids for us to implement a fault tolerant parser for YAML which is a very hard task. As we don't manage custom YAML completion, validation, hover, when you write property expression with {} in yaml value, we cannot add custom behavior, so it is impossible to managecompletion, hover, etc for property expression in yaml file (and System/Env properties).

The only th=hing that we can do is to support System/Env as yaml key, but I'm not sure that it is interesting, right?

@gastaldi
Copy link

Thanks for investigating!

The only th=hing that we can do is to support System/Env as yaml key, but I'm not sure that it is interesting, right?

Right, I believe they are mostly used as YAML values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants