feat: Resolve system properties/environment variables while browsing the application.properties values

[angelozerr]

feat: Resolve system properties/environment variables while browsing the application.properties values

Fixes #448

Here the result:

//cc @gastaldi

[datho7561]

Hovering on the system property/environment variable names causes an error popup, and the following is logged in the language server logs:

Request failed: Request microprofile/propertyDocumentation failed with message: Command 'microprofile/propertyDocumentation' must be called with required MicroProfilePropertyDocumentationParams.sourceType! (-32603).

[angelozerr]

@datho7561 I cannot reproduce it, could you share a simple example please.

[datho7561]

Opening completions at the |:

quarkus.application.name=${ASDF|}

I am given options corresponding to environment variables. Accepting the suggestion ASDF_DIR results in

quarkus.application.name=|

update: this only seems to be happening to the environment variable results, the Java property ones work fine.

[datho7561]

I cannot reproduce it, could you share a simple example please.

hovering-environment-variable-fails.mp4

The value of ASDF_DIR is /home/davthomp/.asdf

[angelozerr]

Hovering on the system property/environment variable names causes an error popup, and the following is logged in the language server logs:

Hovering on the system property/environment variable names causes an error popup, and the following is logged in the language server logs:

Request failed: Request microprofile/propertyDocumentation failed with message: Command 'microprofile/propertyDocumentation' must be called with required MicroProfilePropertyDocumentationParams.sourceType! (-32603).

It should be fixed.

[angelozerr]

update: this only seems to be happening to the environment variable results, the Java property ones work fine.

They were several issues with completion default items that I have fixed, it should work correctly now. I need to write tests again.

[datho7561]

Sounds good. I checked out the latest commit and confirmed that's working. Once the tests are in place I think it's ready to go.

[angelozerr]

Sounds good. I checked out the latest commit and confirmed that's working. Once the tests are in place I think it's ready to go.

Thanks @datho7561 ! I wrote a lot of tests and I merge it since CI build is working well.