Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST client CodeLens only shows up for GET annotations. #94

Closed
rzgry opened this issue Oct 15, 2020 · 8 comments · Fixed by #309
Closed

REST client CodeLens only shows up for GET annotations. #94

rzgry opened this issue Oct 15, 2020 · 8 comments · Fixed by #309
Assignees
Labels
codelens java-files Features supported in Java files
Milestone

Comments

@rzgry
Copy link
Member

rzgry commented Oct 15, 2020

Currently the MicroProfile REST Client CodeLens only show up for paths annotated with @GET.

I think it makes sense to display them for other annotations like POST or PUT even though they cannot be accessed from the browser. (If possible maybe we could make CodeLens for POST/PUT etc. requests not clickable?)

IE. if u have a rest client with just a POST endpoint, you might still want the CodeLens to appear so you can quickly see the full URL that is configured by your mp-config.properties file.

@rzgry rzgry added java-files Features supported in Java files codelens labels Oct 15, 2020
@angelozerr
Copy link
Contributor

I think it makes sense to display them for other annotations like POST or PUT even though they cannot be accessed from the browser. (If possible maybe we could make CodeLens for POST/PUT etc. requests not clickable?)

The main reason is that POST/PUT should not be clickable. I agree with you, POST/PUT CodeLens should appear but we need to manage click:

@fbricon
Copy link
Contributor

fbricon commented Nov 3, 2020

if the solution to make the links not clickable is to just send a null/empty command, we should do that

@angelozerr
Copy link
Contributor

if the solution to make the links not clickable is to just send a null/empty command, we should do that

It should work.

@rgrunber
Copy link
Contributor

I can have a look.

@angelozerr angelozerr added this to the 0.2.0 milestone Nov 20, 2020
@angelozerr angelozerr modified the milestones: 0.2.0, 0.3.0 Mar 31, 2021
@angelozerr angelozerr modified the milestones: 0.3.0, 0.4.0 Jul 28, 2021
@rgrunber rgrunber removed this from the 0.4.0 milestone Feb 14, 2022
@datho7561
Copy link
Contributor

I've been working through the Quarkus super heros example, and this would be very nice to have. I thought the app/ the Quarkus dev mode was broken when the code lens didn't show up.

@rgrunber rgrunber assigned datho7561 and unassigned rgrunber Nov 1, 2022
@JessicaJHee
Copy link
Contributor

I'm interested in working on this issue!

@rgrunber rgrunber assigned JessicaJHee and unassigned datho7561 Nov 2, 2022
@fbricon
Copy link
Contributor

fbricon commented Nov 2, 2022

codelenses are only shown on GET requests because they're the only types of requests that make sense to provide a hyperlink to

@rgrunber
Copy link
Contributor

rgrunber commented Nov 2, 2022

I think we can have it show up, just that we need to make it non-clickable. #94 (comment) mentions there is a way to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codelens java-files Features supported in Java files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants