Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add REST client CodeLens for additional annotations #309

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Add REST client CodeLens for additional annotations #309

merged 1 commit into from
Nov 15, 2022

Conversation

JessicaJHee
Copy link
Contributor

Fixes #94

Signed-off-by: Jessica He jhe@redhat.com

@rgrunber
Copy link
Contributor

rgrunber commented Nov 9, 2022

test this please.

@datho7561 datho7561 self-requested a review November 9, 2022 18:50
datho7561
datho7561 approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well, and the code looks good! I think we are going to hold off on merging this until after the release, although we should discuss that.

....core/src/main/java/org/eclipse/lsp4mp/jdt/internal/jaxrs/java/JaxRsCodeLensParticipant.java Outdated
@@ -133,7 +133,7 @@ private static void collectURLCodeLenses(IJavaElement[] elements, String rootPat
// @DELETE, @PUT
// JAX-RS
// annotation
if (isJaxRsRequestMethod(method) && Flags.isPublic(method.getFlags())) {
if (isClickableJaxRsRequestMethod(method) && Flags.isPublic(method.getFlags())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about also providing the unclickable urls for the application's own REST endpoints in this PR? When I read the issue initially, that's what I thought it was talking about.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to do that as well. @rgrunber what do you think?

@rgrunber
Copy link
Contributor

Change works well for me. Do we care about HEAD in the event a user decides to customize ? or is that basically overkill.

jaxrs-head-support

@JessicaJHee
Copy link
Contributor Author

Change works well for me. Do we care about HEAD in the event a user decides to customize ? or is that basically overkill.

I didn't include it initially because I thought it wasn't very useful to show, but I can also add it to be consistent since it is allowed?

@rgrunber
Copy link
Contributor

rgrunber commented Nov 14, 2022 •
edited
Loading

Change works well for me. Do we care about HEAD in the event a user decides to customize ? or is that basically overkill.

I didn't include it initially because I thought it wasn't very useful to show, but I can also add it to be consistent since it is allowed?

If it's easy enough, I would add it. It also isn't clickable, mainly because I don't think a web browser would render it (only handles GET).

@JessicaJHee
Add REST client CodeLens for additional annotations
b6115af 
Signed-off-by: Jessica He <jhe@redhat.com>
@rgrunber rgrunber merged commit 167d09e into eclipse:master Nov 15, 2022
@JessicaJHee JessicaJHee deleted the issue94 branch November 15, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

@rgrunber rgrunber rgrunber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REST client CodeLens only shows up for GET annotations.
3 participants
@JessicaJHee @rgrunber @datho7561