-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extensions as nested annotations for extensible models #513
Conversation
We may want to add some additional TCK tests for some random selection of annotations. |
tck/src/main/java/org/eclipse/microprofile/openapi/tck/PetStoreAppTest.java
Outdated
Show resolved
Hide resolved
Should we add the |
Yes, thanks for catching it. |
Should we add |
I'm unsure whether we should add it to |
That's my thinking as well. |
api/src/main/java/org/eclipse/microprofile/openapi/annotations/Components.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/eclipse/microprofile/openapi/annotations/extensions/Extension.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've finished my review and I'd be happy to approve once the comments above are addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good but spotted one issue in the test.
Fixes #339
Fixes #387