Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read nested extensions property from extensible model annotations #1130

Merged

Conversation

MikeEdgar
Copy link
Member

@MikeEdgar MikeEdgar added this to the 3.1.0 milestone Apr 20, 2022
@MikeEdgar MikeEdgar marked this pull request as ready for review April 20, 2022 10:23
@MikeEdgar
Copy link
Member Author

@phillip-kruger please have a look when you get a chance. Once this is merged, I'd like to rebase and merge each of the MP 3.1 milestone PRs in order.

@phillip-kruger
Copy link
Member

hi @MikeEdgar - can you look at the build failures ?

@MikeEdgar
Copy link
Member Author

MikeEdgar commented Apr 26, 2022

@phillip-kruger, several of these PRs will fail because the build is using the MP 3.1 snapshot with new TCK tests. Each one that is rebased should have fewer test failures and the final PR should be green :-) If there is anything still broken after that, I'll open a separate PR to fix.

@phillip-kruger
Copy link
Member

Ok cool. I just wanted to make sure :) Code changes l.g.t.m

@phillip-kruger phillip-kruger merged commit d8b0291 into smallrye:main Apr 26, 2022
@MikeEdgar MikeEdgar deleted the mp3.1-extensions-nested-annotation branch April 26, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants