Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation code cannot allow for *age* varying interest rates #1132

Closed
Mv77 opened this issue Apr 12, 2022 · 4 comments · Fixed by #1221
Closed

Simulation code cannot allow for *age* varying interest rates #1132

Mv77 opened this issue Apr 12, 2022 · 4 comments · Fixed by #1221

Comments

@Mv77
Copy link
Contributor

Mv77 commented Apr 12, 2022

Some time ago, @wdu9 highlighted an issue with the simulation code that prevents age-varying interest rates from being used.

For age varying interest rates, the fix is very simple as @mnwhite and I suggested in that thread:

  • Add Rfree (and Rboro?) to time_vary.
  • Edit get_Rfree() appropriately.

But the issue turned out to be that Will wanted not age-varying but time-varying interest rates. This is much trickier and the discussion spurred plans to separate time and age in HARK and to make the default rate of return risky.

Agree with the plans or not, there is still a very easy fix for age-varying rates, which we don't have yet (this PR does not achieve that, but something else).

An external user emailed me yesterday requesting this feature. I don't have the time to fix it myself in the next two weeks.

@alanlujan91
Copy link
Member

There are still some blocking issues in #1108 that I am trying to work on this week. That PR adds agent type IndShockRiskyAssetConsumerType with an age_varying interest rate, which essentially merges the functionality of IndShockConsumerType and PortfolioConsumerType.

@Mv77 did the external user request this feature for KinkedRConsumerType (since you mentioned Rboro)? The current changes I'm working on would not affect this type, since it does not use Rfree but instead uses Rboro and Rsave.

@mnwhite
Copy link
Contributor

mnwhite commented Apr 12, 2022 via email

@alanlujan91
Copy link
Member

@Mv77 @wdu9 does time/age varying Rfree in simulation works now or is this still outstanding?

@alanlujan91 alanlujan91 mentioned this issue Feb 2, 2023
3 tasks
@Mv77
Copy link
Contributor Author

Mv77 commented Feb 2, 2023

I believe your recent changes should have fixed this, right?

Rfree can now be a list and goes into time_vary? If so, this has been addressed.

@alanlujan91 alanlujan91 linked a pull request Feb 2, 2023 that will close this issue
3 tasks
@alanlujan91 alanlujan91 removed a link to a pull request Feb 2, 2023
3 tasks
@alanlujan91 alanlujan91 linked a pull request Feb 2, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants