Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary and resolving error message #1219

Merged
merged 5 commits into from
Feb 6, 2023
Merged

Conversation

dedwar65
Copy link
Contributor

Commits from 1/16 included:

  • creating a dictionary for the "ConsPortfolioType"
  • resolving the "TypeError" in the final code block, which renders an error message on the documentation site.

dedwar65 and others added 2 commits January 16, 2023 21:48
I've added a dictionary for the "ConsPortfolio" consumer type which matches the syntax of the other classes of AgentTypes in the introductory notebook on the documentation site.
@sbenthall
Copy link
Contributor

The failing test on this PR seems to be about Rfree being a list instead of a float.
Is this connected to this error? sbenthall/SHARKFin#186 (comment) ping @alanlujan91
See #1106 #1132 I think the root problem relates to #664

@alanlujan91 alanlujan91 self-assigned this Feb 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Base: 73.32% // Head: 73.32% // No change to project coverage 👍

Coverage data is based on head (3db2085) compared to base (69e0aa3).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1219   +/-   ##
=======================================
  Coverage   73.32%   73.32%           
=======================================
  Files          74       74           
  Lines       12122    12122           
=======================================
  Hits         8889     8889           
  Misses       3233     3233           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alanlujan91 alanlujan91 mentioned this pull request Feb 2, 2023
3 tasks
@alanlujan91
Copy link
Member

@dedwar65 is this done?

@dedwar65
Copy link
Contributor Author

dedwar65 commented Feb 6, 2023 via email

@alanlujan91
Copy link
Member

Merging these improvements to notebooks before #1221, will fix conflicts there.

@alanlujan91 alanlujan91 merged commit 389c34f into econ-ark:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants