-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set aggregate property on frame #1064
Conversation
@Mv77 could I ask you to review this? Should be quick. |
This looks good to me. I wonder if there are frames that could be joined, like PermShk and TranShk. Too many frames might become too complex to understand for new users. It would also be useful to map frames in the simulation with frames (or subperiods) in the solution method. |
self.shocks = {} | ||
self.controls = {} | ||
self.state_now = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do these get defined now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm i found it
Yes, mapping simulation frames to the solution is a desired next step. There seems to be some difference of opinion about the best way to group frames. The current implementation is agnostic about the best amount of aggregation in framing. That way performance of the same model, differently written, can be tested. One benefit of granular frames is that they support the kind of plotting done in #1071 |
This solves #1063 by setting the aggregate property of a variable on its frame in a FramedAgent.
It also pulls all the FramedAgent logic into its own modules
frames
No new tests -- this is a refactor.
Some docs fixes