feat: Update CSS to Semantic UI v2.3 #371
Labels
Milestone
Comments
|
i think the same, i had to update to 2.3.1 (https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.3.1/semantic.min.css) in my project when i see that 2.2 did not show some icons. but modals were break |
|
I fixed it in my PR #361 I published it so you can use it normally by installing my version: Imports need to change, but after that it will work just fine |
|
I've now merged the PRs that provide this functionality, will be cutting a new |
TroyMurphy
pushed a commit
to TroyMurphy/ng2-semantic-ui
that referenced
this issue
Aug 23, 2018
edcarroll#371) * fix(dimmer): Fixed dimmer to work correctly with SUI v2.3.0 * fix(modal): Fixed modal positioning for SUI v2.3.0 * chore: Updated SUI version to 2.3.1 * chore: Fixed typescript dependency version * feat(modal): Added isCentered property * doc(modal): Updated API description * docs(modal): Fixed a typo in a property description * fix(modal): Fixed barrel reference & private `HostBinding`
avohra
pushed a commit
to avohra/ng2-semantic-ui
that referenced
this issue
Oct 6, 2018
edcarroll#371) * fix(dimmer): Fixed dimmer to work correctly with SUI v2.3.0 * fix(modal): Fixed modal positioning for SUI v2.3.0 * chore: Updated SUI version to 2.3.1 * chore: Fixed typescript dependency version * feat(modal): Added isCentered property * doc(modal): Updated API description * docs(modal): Fixed a typo in a property description * fix(modal): Fixed barrel reference & private `HostBinding`
anoophm
added a commit
to project-sunbird/ng2-semantic-ui
that referenced
this issue
Mar 25, 2019
* chore: Update to Angular 6 (edcarroll#398) * chore: Moved to newest Angular CLI * fix: Fixed rxjs references * chore: Deleted migration folder * style: Fixed tslint errors in test * fix: Updated all class HostBindings to be public * fix: Updated all HostListener bindings to be public * fix(collapse): Fixed HostBinding modifiers * fix(collapse): Fixed isCollapsed HostBinding * fix: Updated remaining HostBindings to be public * feat: Made all hasClasses properties readonly * revert: "feat: Made all hasClasses properties readonly" This reverts commit 2f78b5c. * feat: Updated getter only properties to use readonly modifier * fix(demo): Fixed ApiDefinition typings * fix(localization): Fixed compilation of locales * chore: Moved some deps from peer to normal * fix: Added library dependencies to whitelist * test: Fixed all tests * style(demo): Fixed polyfill lint errors * test: Updated Travis to use NPMv6 * test: Removed superfluous lint from Travis config * chore: Fixed loop in package scripts * test: Reverted to npm@5 for Travis * chore: Added conf.js ignore to gitignore * fix: AOT Compilation in Angular 6 & SystemJS (edcarroll#400) * fix: Fixed AOT when imported as library Fixes edcarroll#209 * fix(demo): Fixed SuiPopupConfig injector error * refactor: Renamed all `index` files to `internal` This will ensure that no imports are accidentally created using just the directory name, which causes endless problems with Angular's CLI * fix(demo): Fixed stack overflow in compilation * fix: Performance issues due to document listeners (edcarroll#399) (Closes edcarroll#284) * Fix issue with slow typeaheads * Remove check for contains since listener is now on native element * feat(search): Remove reliance on document event * fix(popup): Fixed performance issues due to excessive document listeners * fix(popup): Fixed missing nullcheck * feat(select): Removed reliance on separate keydown listener * chore(demo): Updated environment config to match latest angular * feat(demo): Removed dev environment file * feat(dropdown): Fully removed document listener * fix: Broken merge * fix(dropdown): Parent element accessed before initialisation (edcarroll#401) * fix(dropdown): Fixed parentElement being accessed before initialisation * chore: Bumped version * fix: Keyboard navigation in select component (edcarroll#402) * fix(dropdown): Parent element accessed before initialisation (edcarroll#408) * fix(dropdown): Fixed parentElement being accessed before initialisation * chore: Bumped version * fix(dropdown): Dropdown menu isOpen of undefined (edcarroll#380) * fix(select): Fixed nested labelField and valueField error (edcarroll#405) (Closes edcarroll#381) * feat(popup): Added `isFlowing` and `isInline` properties (edcarroll#385) * feat(popup): Added arrow centering, size and width properties (edcarroll#350) * feat(popup): Added size and width properties * feat(popup): Added arrow centering on small popup anchors * fix(popup): Corrected popup positioning, removed double popper update * fix(popup): Added timeout for positioning service create * fix(modal): Fixed modal positioning for SUI v2.3 (edcarroll#362) (Closes edcarroll#371) * fix(dimmer): Fixed dimmer to work correctly with SUI v2.3.0 * fix(modal): Fixed modal positioning for SUI v2.3.0 * chore: Updated SUI version to 2.3.1 * chore: Fixed typescript dependency version * feat(modal): Added isCentered property * doc(modal): Updated API description * docs(modal): Fixed a typo in a property description * fix(modal): Fixed barrel reference & private `HostBinding` * docs: Updated Angular and Semantic UI versions * chore: Bumped alpha version * fix: Removed private label from package json * chore: Added prepublishOnly script to ensure final compilation before publish * chore: Bumped alpha version * Issue #SB-10187 fix: updating angular version * Issue #SB-10187 fix: updating angular version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Update css version
Actually, https://edcarroll.github.io/ng2-semantic-ui/#/getting-started recommends to use semantic css 2.2.13, but this implies that some elements are missing compare to recent css versions (like icons).
The update breaks some components
For example, when semantic 2.3.1 is used, modal positions are broken.
Could you please consider to upgrade css version for ng2-semantic-ui ?
The text was updated successfully, but these errors were encountered: