Fixed broken modals in SemanticUI 2.3 #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed close icon on modal, as it's not in the original SUI at all
as it's a new feature in SUI 2.3
4 tasks
| @@ -139,6 +140,10 @@ export class SuiModal<T, U> implements OnInit, AfterViewInit { | |||
| this._isInverted = Util.DOM.parseBooleanAttribute(inverted); | |||
| } | |||
|
|
|||
| // Wheter or not the modal should be placed in the center of the page. When `false` it will be aligned to the top of the page | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure you have at least performed the following:
The new Semantic UI in version 2.3 was breaking all modals, so I fixed them in your library.
Additionally I've added bindings for the new property in the modals as well.
To actually make it working I had to adjust
package.jsonconfig as the newest version of TypeScript was used by default and it wasn't my intention to rewrite your whole repository to make it compliant with changes in TS 2.7 and compatible tslint.Tests were not working for me at all, so I did not change them.