WIP: Fix get_code_params for Python 3.10 #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckled successfully.
|
From Travis. So it looks like the transition to GitHub Actions will have to happen. |
jun66j5
reviewed
Sep 22, 2021
| @@ -7,7 +7,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: [2.7, 3.6, 3.7, 3.8, 3.9, '3.10-dev', pypy2, pypy3] | |||
| python-version: [2.7, 3.4, 3.5, 3.6, 3.7, 3.8, 3.9, '3.10-dev', '3.11-dev', pypy2, pypy3] | |||
There was a problem hiding this comment.
Python 3.4 on ubuntu-latest (20.04) is not available but available on ubuntu-18.04.
See:
There was a problem hiding this comment.
Assuming we want to continue supporting Python 3.4/3.5 jun66j5/genshi@9f462c3 is a good approach. jun66j5/genshi@5908c14d should be replaced by pip install -e . or python setup.py develop though. Would you mind submitting a PR?
|
I'm happy to drop CI for Python 3.4 and 3.5 for now and get_code_params was fixed elsewhere, so closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #43 and #37 it was reported that the arguments to
code(...)have changed in Python 3.10. This affects thebuild_code_chunkandget_code_paramsfunctions ingenshi.compat.build_code_chunkwas fixed in #49. This PR is intended to fixget_code_params.WIP: Currently this PR only attempts to get the tests to fail.