Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix get_code_params for Python 3.10 #50

Closed
wants to merge 3 commits into from
Closed

WIP: Fix get_code_params for Python 3.10 #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
172dc1b
Add check that expression and suite code objects are pickled and unpi…
hodgestar Sep 17, 2021
bf05f30
Merge branch 'master' into feature/fix-get-code-params-for-python-3.10
hodgestar Sep 20, 2021
1f13447
Try add Python 3.4, 3.5 and 3.11-dev to the test matrix.
hodgestar Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [2.7, 3.6, 3.7, 3.8, 3.9, '3.10-dev', pypy2, pypy3]
python-version: [2.7, 3.4, 3.5, 3.6, 3.7, 3.8, 3.9, '3.10-dev', '3.11-dev', pypy2, pypy3]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.4 on ubuntu-latest (20.04) is not available but available on ubuntu-18.04.

See:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we want to continue supporting Python 3.4/3.5 jun66j5/genshi@9f462c3 is a good approach. jun66j5/genshi@5908c14d should be replaced by pip install -e . or python setup.py develop though. Would you mind submitting a PR?


steps:
- uses: actions/checkout@v2
Expand All @@ -19,4 +19,3 @@ jobs:
- name: Run test suite
run: |
python setup.py test

2 changes: 2 additions & 0 deletions genshi/template/tests/eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def test_pickle(self):
buf.seek(0)
unpickled = pickle.load(buf)
assert unpickled.evaluate({}) is True
assert unpickled.code == expr.code

def test_name_lookup(self):
self.assertEqual('bar', Expression('foo').evaluate({'foo': 'bar'}))
Expand Down Expand Up @@ -552,6 +553,7 @@ def test_pickle(self):
data = {}
unpickled.execute(data)
self.assertEqual(42, data['foo'])
assert unpickled.code == suite.code

def test_internal_shadowing(self):
# The context itself is stored in the global execution scope of a suite
Expand Down