refactor!: Use config stem from common constants #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested review from
bnevis-i,
cherrycl,
cloudxxx8 and
jim-wang-intel
lenny-goodell
force-pushed
the
config-stems
branch
from
852719f to
f0a46d3
Compare
bnevis-i
previously approved these changes
Dec 3, 2022
5 tasks
jim-wang-intel
previously approved these changes
Dec 5, 2022
BREAKING CHANGE: Location of service's configuration in Consul has changed closes edgexfoundry#1236 Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
lenny-goodell
dismissed stale reviews from jim-wang-intel, cloudxxx8, and bnevis-i
via
b6b21e0
lenny-goodell
force-pushed
the
config-stems
branch
from
f0a46d3 to
b6b21e0
Compare
bnevis-i
previously approved these changes
Dec 13, 2022
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
|
recheck |
1 similar comment
|
recheck |
jim-wang-intel
approved these changes
Dec 13, 2022
bnevis-i
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Location of service's configuration in Consul has changed
closes #1236
Signed-off-by: Leonard Goodell leonard.goodell@intel.com
This PR is dependent on the following PR to be merged first then update the go.mod
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
Build and run app template with edgex stack running
Verify the service configuration is pushed to
edgex/3.0/app-new-serviceNew Dependency Instructions (If applicable)