Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change to use new flattened Consul paths #744

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

lenny-goodell
Copy link
Member

closes #743

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

Note

This PR is dependent on the following PRs being merged:

And the dependencies propagated to:

  • Device SDK
  • ASC
  • Device Services.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

cloudxxx8
cloudxxx8 previously approved these changes Dec 5, 2022
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bnevis-i
bnevis-i previously approved these changes Dec 5, 2022
@lenny-goodell lenny-goodell dismissed stale reviews from bnevis-i and cloudxxx8 via f4b907b December 13, 2022 23:04
@lenny-goodell lenny-goodell force-pushed the flatten-consul-paths branch 2 times, most recently from f4b907b to 8759bd2 Compare December 13, 2022 23:07
@lenny-goodell lenny-goodell marked this pull request as ready for review December 13, 2022 23:07
@lenny-goodell
Copy link
Member Author

lenny-goodell commented Dec 13, 2022

@cloudxxx8 , this PR is now ready.
device-rest and device-virtual and device-modbus still need to be updated with latest SDK so some tests will still fail.

bnevis-i
bnevis-i previously approved these changes Dec 13, 2022
closes edgexfoundry#743

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Copy link
Contributor

@cherrycl cherrycl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cherrycl cherrycl merged commit 09ae719 into edgexfoundry:main Dec 14, 2022
@lenny-goodell lenny-goodell deleted the flatten-consul-paths branch June 12, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Consul paths to access service configuration for new flattened structure
4 participants