refactor!: Use common Config Stem constants for Core Contracts #4243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
force-pushed
the
remove-config-stems
branch
from
c8784f1 to
aa23d0e
Compare
lenny-goodell
requested review from
jim-wang-intel,
bnevis-i,
cherrycl and
cloudxxx8
lenny-goodell
force-pushed
the
remove-config-stems
branch
from
aa23d0e to
3740f93
Compare
bnevis-i
previously approved these changes
Dec 2, 2022
5 tasks
lenny-goodell
dismissed stale reviews from cloudxxx8, bnevis-i, and jim-wang-intel
via
5316d1b
lenny-goodell
force-pushed
the
remove-config-stems
branch
2 times, most recently
from
5316d1b to
32c5e47
Compare
lenny-goodell
force-pushed
the
remove-config-stems
branch
2 times, most recently
from
37fb671 to
284eb16
Compare
jim-wang-intel
previously approved these changes
Dec 13, 2022
BREAKING CHANGE: Location of service configuration in Consul changed closes edgexfoundry#4242 Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
remove-config-stems
branch
from
284eb16 to
795f556
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jim-wang-intel
approved these changes
Dec 13, 2022
Codecov Report
@@ Coverage Diff @@
## main #4243 +/- ##
=======================================
Coverage 43.29% 43.29%
=======================================
Files 125 125
Lines 11126 11126
=======================================
Hits 4817 4817
Misses 5896 5896
Partials 413 413
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bnevis-i
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Location of service configuration in Consul changed
closes #4242
Signed-off-by: Leonard Goodell leonard.goodell@intel.com
Note: this PR is dependent on the following PR being merged first.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
Build and run core/support services with edgex stack running (core/support services stopped)
Verify configuration is pushed to /edgex/3.0/
New Dependency Instructions (If applicable)