feat(security): Document DefaultTokenTTL and ssl_cipher_suite override #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnevis-i
changed the title
This was referenced Sep 8, 2021
lenny-goodell
added
hold
lenny-goodell
requested changes
Sep 9, 2021
|
@bnevis-i The DCO check is now failing. You need to amend your last commit with sign-off. |
Closes #553 Closes edgex-go-3680 Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
lenny-goodell
approved these changes
Oct 5, 2021
edgex-jenkins
added a commit
that referenced
this pull request
Oct 5, 2021
…rride (#560) Signed-off-by: edgex-jenkins <collab-it+edgex@linuxfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #553
Closes edgexfoundry/edgex-go#3680
Signed-off-by: Bryon Nevis bryon.nevis@intel.com
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/master/.github/Contributing.md.
What is the current behavior?
DefaultTokenTTL override is undocumented.
Issue Number:
What is the new behavior?
DefaultTokenTTL override is documented.
Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information