Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(security): Enable modern cipher suite / TLSv1.3 only #3704

Merged
merged 2 commits into from
Sep 9, 2021
Merged

feat(security): Enable modern cipher suite / TLSv1.3 only #3704

merged 2 commits into from
Sep 9, 2021

Conversation

bnevis-i
Copy link
Collaborator

@bnevis-i bnevis-i commented Sep 8, 2021

Closes #3680

Signed-off-by: Bryon Nevis bryon.nevis@intel.com

PR Checklist

Please check if your PR fulfills the following requirements:

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.

What is the current behavior?

API gateway supports "intermediate" level of cipher suites.

Issue Number:

What is the new behavior?

API gateway supports "modern" cipher suite and TLSv1.3 only.

Does this PR introduce a breaking change?

  • Yes, but can by changed by configuration alone.
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

Closes #3680

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
@bnevis-i bnevis-i marked this pull request as ready for review September 8, 2021 19:03
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #3704 (b76c258) into main (a77f58c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3704   +/-   ##
=======================================
  Coverage   47.27%   47.27%           
=======================================
  Files         112      112           
  Lines        9180     9180           
=======================================
  Hits         4340     4340           
  Misses       4466     4466           
  Partials      374      374           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77f58c...b76c258. Read the comment docs.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bnevis-i bnevis-i merged commit 7380b5b into edgexfoundry:main Sep 9, 2021
@bnevis-i
Copy link
Collaborator Author

bnevis-i commented Sep 9, 2021

Merging based on successful TAF results in Docker.

@bnevis-i bnevis-i deleted the edgex-go-3680 branch September 9, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit and bump TLS security level for API gateway
3 participants