fix(snap): source security-bootstrapper config overrides from env file #4283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #4071 upgraded the library to generate correct environment files, and updated the env loader script accordingly. However, another env file loader logic was in the consul security bootstrapper script which was left out.
This PR removes the duplicate logic and makes the bootstrapper use the generic env file loader script.
Fixes #4284
Signed-off-by: Farshid Tavakolizadeh farshid.tavakolizadeh@canonical.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
sudo snap install edgex-device-mqtt --edge && sudo snap connect edgexfoundry:edgex-secretstore-token edgex-device-mqtt:edgex-secretstore-token
sudo snap install mosquitto
)sudo snap start edgex-device-mqtt
New Dependency Instructions (If applicable)