-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JU-11 Add the ability to customize the registration fields #580
Conversation
79355c1
to
02c0e7b
Compare
""" | ||
custom_fields = getattr(settings, "EDNX_CUSTOM_REGISTRATION_FIELDS", []) | ||
for field in custom_fields: | ||
if field.get("name") == field_name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if we made this case insensitive? :thinking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariajgrimaldi I'm curious as to why do you think that would be useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{
"label": "Celular",
"name": "mobile",
"type": "text"
}
==
{
"label": "Celular",
"name": "Mobile",
"type": "text"
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariajgrimaldi you're right, I'm changing it. Thankss for the suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariajgrimaldi done. I also changed the EXTRA_FIELDS method to avoid duplicates and to also make sure that field_name
is always lowercase. What do you think?
can you add optional fields to your tests settings? |
247ba42
to
0834a07
Compare
…and EDNX_CUSTOM_REGISTRATION_FIELDS
0834a07
to
b8a2599
Compare
This feature adds the ability to customize the registration form
IMPORTANT
There is a typo HERE that was fixed in this PR #583
Documentation
https://docs.google.com/document/d/1XpVO596QXbx6IAzo88jiHMxH08tCO3s-NXx85TWjrB0/edit
For further context about the implementation, you can refer to the PRs description from the Juniper migration, where the feature was added.
PRs from previous migration
#458
#463
#481
#494
Minor changes in the code for Lilac
six.text_type() --> str()
isinstance( , six.string_types) --> isinstance(, str)
Testing
Microsite settings