-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JU-11 Add the ability to customize the registration fields (DS-303) #691
Conversation
d152b75
to
aaea436
Compare
@mariajgrimaldi @felipemontoya what are your thoughts on this? |
aaea436
to
4bacfde
Compare
Thank you @MaferMazu, i focused in the implementation and forget to change these names. I made some changes, can you check again? |
4bacfde
to
1df9cf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure with some classes names, but I think this would be a conversation in upstream PRs.
I tested it and it's working as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I tested the extra fields and the scripts. I had problems testing the alert on the login page (I tried using /login and /login.*, maybe is something wrong in my config); if you can test it, I don't have problems merging this.
On the other hand, please update the doc in this PR and in the drive for leave instructions on how to test this with filters and Tenant Config; we want to deprecate Microsite.
I'm ok with the way this was implemented in this PR, but I wonder if we use the StudentRegistrationRequested for part of this logic. Would it make sense to alter the form only at theme and later receive those fields in the StudentRegistrationRequested filter for processing? |
This feature adds the ability to customize the registration form
Documentation
https://docs.google.com/document/d/1XpVO596QXbx6IAzo88jiHMxH08tCO3s-NXx85TWjrB0/edit
For further context about the implementation, you can refer to the PRs description from the Juniper migration, where the feature was added.
PRs from previous migration
About the code refactor
The idea is support this feature as a filter pipeline, so this refactor is in order to take it as example to sustent the filter in the upstream PR.
Testing
Microsite settings
Now you look at registration form in /register
in /admin/auth/user/
In account/settings you should look your custom field types, for this example Type Document as List instead of plain text.