perf: add support of css-variables to redwood #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoa
approved these changes
May 27, 2024
bra-i-am
added a commit
that referenced
this pull request
Jul 22, 2024
bra-i-am
added a commit
that referenced
this pull request
Jul 23, 2024
bra-i-am
added a commit
that referenced
this pull request
Jul 23, 2024
bra-i-am
added a commit
that referenced
this pull request
Jul 31, 2024
* perf: add css-variables support to redwood (#6) * fix: import `FooterSlot` from `frontend-slot-footer` package (openedx#1048) * fix: use `frontend-slot-footer` that supports all footer versions The previous version of `frontend-slot-footer` had a peer dependency of `^14.0.0`, which caused problems for some methods of installing forked footers. This updates to a version of `frontend-slot-footer` that allows for *any* version of `frontend-component-footer` in the peer dependency. * refactor: add proper footer-slot * refactor: update plugin framework branch name --------- Co-authored-by: Brian Smith <112954497+brian-smith-tcril@users.noreply.github.com> Co-authored-by: Brian Smith <bsmith@axim.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds compatibility of runtime theming to Redwood
JIRA Issue DS-919