Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import FooterSlot from frontend-slot-footer package #1048

Conversation

brian-smith-tcril
Copy link
Contributor

No description provided.

@brian-smith-tcril brian-smith-tcril force-pushed the footerslot-from-footerslot-package branch 2 times, most recently from 1891a07 to b5d880f Compare May 15, 2024 16:27
@brian-smith-tcril brian-smith-tcril force-pushed the footerslot-from-footerslot-package branch from b5d880f to 96ea1d4 Compare May 15, 2024 19:44
@brian-smith-tcril brian-smith-tcril marked this pull request as ready for review May 15, 2024 19:54
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@brian-smith-tcril brian-smith-tcril merged commit 16fb3a1 into openedx:master May 15, 2024
7 checks passed
bra-i-am pushed a commit to eduNEXT/frontend-app-account that referenced this pull request Jul 23, 2024
bra-i-am pushed a commit to eduNEXT/frontend-app-account that referenced this pull request Jul 23, 2024
bra-i-am added a commit to eduNEXT/frontend-app-account that referenced this pull request Jul 31, 2024
* perf: add css-variables support to redwood (#6)

* fix: import `FooterSlot` from `frontend-slot-footer` package (openedx#1048)

* fix: use `frontend-slot-footer` that supports all footer versions

The previous version of `frontend-slot-footer` had a peer dependency of `^14.0.0`, which caused problems for some methods of installing forked footers. This updates to a version of `frontend-slot-footer` that allows for *any* version of `frontend-component-footer` in the peer dependency.

* refactor: add proper footer-slot

* refactor: update plugin framework branch name

---------

Co-authored-by: Brian Smith <112954497+brian-smith-tcril@users.noreply.github.com>
Co-authored-by: Brian Smith <bsmith@axim.org>
hinakhadim pushed a commit to edly-io/frontend-app-account that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants