Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes and extends #3 - Item.Duration rework #4

Merged
merged 6 commits into from
Feb 19, 2017
Merged

fixes and extends #3 - Item.Duration rework #4

merged 6 commits into from
Feb 19, 2017

Conversation

eduncan911
Copy link
Owner

@eduncan911 eduncan911 commented Feb 19, 2017 •
edited
Loading

fixes #3 - Item.Duration being set incorrectly.

  • removing override
  • adding clear documentation
  • changing api parameter name

adding Item.AddDuration

  • will eventually format seconds for HH:MM:SS format per iTunes specs

updated test coverage
bumped version to 1.3

@eduncan911 eduncan911 mentioned this pull request Feb 19, 2017
Closed
@eduncan911 eduncan911 changed the title fixes and extends #2 - Item.Duration rework fixes and extends #3 - Item.Duration rework Feb 19, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling eaa3609 on issue-2-bug-in-duration-setter into 4c753cf on master.

@eduncan911 eduncan911 merged commit b288862 into master Feb 19, 2017
@eduncan911 eduncan911 deleted the issue-2-bug-in-duration-setter branch February 19, 2017 16:42
eduncan911 added a commit that referenced this pull request Feb 7, 2020
@eduncan911
# This is a combination of 9 commits.
0104e21 
# This is the 1st commit message:

Go Mod and Vendor

# This is the commit message #2:

asd

# This is the commit message #3:

asd

# This is the commit message #4:

asd

# This is the commit message #5:

asd

# This is the commit message #6:

asd

# This is the commit message #7:

asd

# This is the commit message #8:

asd

# This is the commit message #9:

asd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mixup between enclosure.length and itunes:duration
2 participants
@eduncan911 @coveralls