Correctly count len of UTF8 strings (fix panics) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduncan911
approved these changes
Dec 10, 2017
|
And sorry for the delay. I didn't see the notification for this. |
|
In the future, let's branch and PR against |
eduncan911
pushed a commit
that referenced
this pull request
Feb 4, 2020
* Correct count len of UTF8 strings (#9) * Correctly count len of UTF8 strings (fix panics) * Sort header * Fixes Panics * Will implement duration parser (#8) * Implement duration parser * Fix example * Increase coverage to 100% * Fix Github and GoDocs Markdown (#14) * GH Markdown fixes * Updated format for godoc * Move podcast.go Private Methods to Respected Files (#12) * close #10 * remove exported function types * remove parseDateRFC1123Z function type * Allow providing GUID on Podcast (#15) * Allow providing own GUID * Check length instead of comparing to empty string * Adding test for user supplied GUID * Remove coveralls token Co-authored-by: Maksym Pavlenko <makpav@amazon.com> Co-authored-by: Konstantin Chukhlomin <mail@chuhlomin.com> Co-authored-by: iwittkau <iwittkau@users.noreply.github.com> Co-authored-by: Damian Szeluga <damian.szeluga@gmail.com>
Merged
eduncan911
added a commit
that referenced
this pull request
Feb 5, 2020
* Catching Develop up to Master (#17) * Correct count len of UTF8 strings (#9) * Correctly count len of UTF8 strings (fix panics) * Sort header * Fixes Panics * Will implement duration parser (#8) * Implement duration parser * Fix example * Increase coverage to 100% * Fix Github and GoDocs Markdown (#14) * GH Markdown fixes * Updated format for godoc * Move podcast.go Private Methods to Respected Files (#12) * close #10 * remove exported function types * remove parseDateRFC1123Z function type * Allow providing GUID on Podcast (#15) * Allow providing own GUID * Check length instead of comparing to empty string * Adding test for user supplied GUID * Remove coveralls token Co-authored-by: Maksym Pavlenko <makpav@amazon.com> Co-authored-by: Konstantin Chukhlomin <mail@chuhlomin.com> Co-authored-by: iwittkau <iwittkau@users.noreply.github.com> Co-authored-by: Damian Szeluga <damian.szeluga@gmail.com> * Update doc.go for release notes * Update README for Release Co-authored-by: Jader Brasil <jaderebrasil@gmail.com> Co-authored-by: Maksym Pavlenko <makpav@amazon.com> Co-authored-by: Konstantin Chukhlomin <mail@chuhlomin.com> Co-authored-by: iwittkau <iwittkau@users.noreply.github.com> Co-authored-by: Damian Szeluga <damian.szeluga@gmail.com>
eduncan911
added a commit
that referenced
this pull request
Feb 7, 2020
# This is the 1st commit message: Go Mod and Vendor # This is the commit message #2: asd # This is the commit message #3: asd # This is the commit message #4: asd # This is the commit message #5: asd # This is the commit message #6: asd # This is the commit message #7: asd # This is the commit message #8: asd # This is the commit message #9: asd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current implementation
AddSubTitlepanics for strings likeU17.com - 有妖氣官方頻道丨《鎮魂街》熱血來襲！每週四精彩更新！. This is becauselenreturns the length of string in bytes instead of length in runes (runes = 33, len in bytes > 64), which cases invalid slice range and panics.@eduncan911 can you review pls?