Skip to content

Commit

Permalink
demo: move mesh delete command into the cleanup script (openserviceme…
Browse files Browse the repository at this point in the history
…sh#1831)

It is useful to run the cleanup script by itself. The mesh
delete command must also be run to cleanup mesh resources
created by install. This change moves the mesh delete command
into the cleanup script so that this single cleanup script
can be used to clean up all resources deployed by the demo.

Signed-off-by: Shashank Ram <shashank08@gmail.com>
  • Loading branch information
shashankram authored and eduser25 committed Oct 14, 2020
1 parent 225cfe2 commit 50e3a1f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions demo/clean-kubernetes.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ set -aueo pipefail
# shellcheck disable=SC1091
source .env

bin/osm mesh uninstall -f --mesh-name "$MESH_NAME" --namespace "$K8S_NAMESPACE"

for ns in "$BOOKWAREHOUSE_NAMESPACE" "$BOOKBUYER_NAMESPACE" "$BOOKSTORE_NAMESPACE" "$BOOKTHIEF_NAMESPACE" "$K8S_NAMESPACE"; do
kubectl delete namespace "$ns" --ignore-not-found --wait &
done
Expand Down
1 change: 0 additions & 1 deletion demo/run-osm-demo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ docker info > /dev/null || { echo "Docker daemon is not running"; exit 1; }
make build-osm

# cleanup stale resources from previous runs
bin/osm mesh uninstall -f --mesh-name "$MESH_NAME" --namespace "$K8S_NAMESPACE"
./demo/clean-kubernetes.sh

# The demo uses osm's namespace as defined by environment variables, K8S_NAMESPACE
Expand Down

0 comments on commit 50e3a1f

Please sign in to comment.